Skip to content

Coverage report: orange for untested lines, blue for full coverage - #40

Merged
cedricvogel-leo merged 1 commit into
mainfrom
fix/coverage-colours
Oct 29, 2026
Merged

cedricvogel-leo merged 1 commit into
mainfrom
fix/coverage-colours

Conversation

@cedricvogel-leo

Copy link
Copy Markdown
Collaborator

P23 follow-up, the instructor's decision of 2026-10-29: the coverage report's two states can be told apart at a glance. Texts, behaviour, check-runtime-coverage.py and the protocol are unchanged; only styling.

Changes

  • Untested lines («Von keinem Beispiel ausgeführt:»): --glp-warning-bg with a --glp-warning bar on the left. These are the colours of the line marks in the IDE's editor, so box and marks belong together.
  • Full coverage: a light blue info box, using the new tokens --glp-info-bg #E3EEFA and --glp-info #1D5B9A (bar). Not green, unlike the «n von n Beispielen bestanden» line above it.
  • Same styling in the embed and the IDE: both use style.css.
  • README «Look»: the token table lists the info tokens and what the warning tokens now also colour.

Contrast (WCAG 2.x, light theme)

Ratio Requirement
Text --glp-text #1A1A1A on --glp-warning-bg #FFF4E5 16.0:1 AA text 4.5:1
Text #1A1A1A on --glp-info-bg #E3EEFA 14.8:1 AA text 4.5:1
Orange bar #8A4B00 on its box / on the console #F3F4F6 6.3:1 / 6.3:1 non-text 3:1
Blue bar #1D5B9A on its box / on the console 5.9:1 / 6.3:1 non-text 3:1

The pale fills differ from the grey console mainly in hue (lightness ratio 1.01–1.07:1). The bars and the heading text carry the distinction, so colour is never the only signal.

Dark mode

glpython has no dark theme. All --glp-* tokens exist only in light, Monaco uses the light vs base, and the macro keeps the block light in LiaScript's dark mode on purpose. So the info tokens are light-only like all others, and there are no dark-mode screenshots. A dark theme would be its own piece of work (all tokens plus the Monaco theme).

Checked

  • Lint (known warning only), both builds, test:console (Chrome, Pyodide).
  • Screenshots of the embed and the IDE (local build), both states: bewertung (orange box, and in the IDE the mark on line 11) and ist_genuegend (blue box).
  • The computed styles in the IDE are the token values.

After the merge: tag v0.1.18, then the IDE bump.

🤖 Generated with Claude Code

The two states of the coverage after Tests can now be told apart at a
glance. Lines no example ran get the colours of their marks in the IDE's
editor (--glp-warning-bg, --glp-warning bar). Full coverage gets a light
blue info box (new tokens --glp-info-bg #E3EEFA, --glp-info #1D5B9A):
distinct from the grey console, and never green like «bestanden», since
covered code can still be wrong. Texts and behaviour are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cedricvogel-leo
cedricvogel-leo merged commit 07f11de into main Oct 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant